Some advice please, did i do the right thing by ending it with him?

It's strange to me that you're even questioning your decision to break it off with this man. He is a loser and you are allowing him to treat you this way. You will never have better if you don't demand it. He will never treat you right so quit wasting your time. As far as the other guy leave it alone. If he's interested he will pursue you. You need to work on yourself right now. I don't understand how women think they absolutely have to have a man in their life to be happy. You need to find a friend that can give you a little support. You mentioned domestic violence. Well there are support groups out there for that. Maybe this would be a good place to start getting the help you need. Without help you might just find yourself in this same situation again. You deserve to be happy...Don't settle for less!